Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Site Connections test suite #2

Closed
3 tasks
tlovett1 opened this issue Sep 30, 2016 · 3 comments
Closed
3 tasks

Network Site Connections test suite #2

tlovett1 opened this issue Sep 30, 2016 · 3 comments
Assignees
@thaicloud
Labels
needs:tests This requires tests.
Milestone
1.0

Comments

@tlovett1
Copy link
Member

tlovett1 commented Sep 30, 2016 •
edited
Loading

There should be separate tests files for both NetworkSiteConnections.php and InternalConnections/NetworkSiteConnection.php.

For NetworkSiteConnection.php, we will need to test:

  • Push
  • Pull
  • Remote get
@tlovett1 tlovett1 added the needs:tests This requires tests. label Sep 30, 2016
@tlovett1 tlovett1 added this to the 1.0 milestone Sep 30, 2016
zanematthew pushed a commit that referenced this issue Oct 21, 2016
Test push
05ad528 
Adding unit test for the network site connection push method, #2.
zanematthew pushed a commit that referenced this issue Oct 21, 2016
Created new branch per issue.
efd775c 
Added unit test for push method, #2
zanematthew pushed a commit that referenced this issue Oct 21, 2016
Moving code into the setup method, #2
d5173ea
zanematthew pushed a commit that referenced this issue Oct 21, 2016
Completing test for pull method, #2
eb55dfc
@zanematthew zanematthew mentioned this issue Oct 21, 2016
Merged
zanematthew pushed a commit that referenced this issue Oct 24, 2016
Network site connection remote get test added, #2
8be66f4
@zanematthew
Copy link

zanematthew commented Oct 26, 2016 •
edited
Loading

@tlovett1 there isn't a method relating to "Connection checking" in the NetworkSiteConnection, class found here, did the code change?

Also from what I gather the extending class is no longer used?

@tlovett1
Copy link
Member Author

The class is definitely used. However, no connection checking is necessary since it's internal.

@zanematthew
Copy link

zanematthew commented Nov 11, 2016 •
edited
Loading

I've re-visited the push() method, and did notice that if wp_insert_post fails that the returned item is a WP error. I've added another for this.

I know based on prior comments we're not testing HTML, and some methods have a higher priority than others. Specifically which other methods should we test?

This test was actually done on a different branch 707dbf8

zanematthew pushed a commit that referenced this issue Dec 1, 2016
Updating push() test to include testing of update_post_meta() arg…
144570b 
…uments, #2.
zanematthew pushed a commit that referenced this issue Dec 1, 2016
Updating pull() test to test for update_post_meta() arguments, #2.
2aea182
@tlovett1 tlovett1 closed this as completed Dec 2, 2017
@khiser khiser mentioned this issue Jan 25, 2021
Closed
@stephen-clark stephen-clark mentioned this issue Aug 30, 2021
Open
@LucyTurtle LucyTurtle mentioned this issue Nov 22, 2021
Closed
@westminsterfl westminsterfl mentioned this issue Sep 20, 2023
Open
jeffpaul added a commit that referenced this issue Sep 19, 2024
@jeffpaul @github-advanced-security
Fix code scanning alert #2: DOM text reinterpreted as HTML
496f3ff 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thaicloud thaicloud

Labels
needs:tests This requires tests.
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@thaicloud @zanematthew @tlovett1