Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps to example workflow around ZIP generation #4

Closed
helen opened this issue Aug 31, 2019 · 1 comment · Fixed by #37
Closed

Add steps to example workflow around ZIP generation #4

helen opened this issue Aug 31, 2019 · 1 comment · Fixed by #37
Assignees
Labels
needs:documentation This requires documentation. type:enhancement New feature or request.
Milestone

Comments

@helen
Copy link
Collaborator

helen commented Aug 31, 2019

Is your enhancement related to a problem? Please describe.
With the new .distignore method of excluding files from deployment, the GitHub-generated ZIP file attached to releases no longer reflects what gets deployed to .org. Also, broadly that automatic naming is an issue, as you'll get plugin-slug-X.Y.Z as the folder name upon unzipping, which is not really what you or WordPress want.

Describe the solution you'd like
Test additional steps in a test repo workflow and then add them to README.md. My sense is that existing Actions can be leveraged to generate the ZIP and attach it to a release, but don't know yet. If not, we can write one, which will also be useful for plugins that don't release to .org at all and update directly from GH instead.

@shivapoudel
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:documentation This requires documentation. type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants