Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add support for React 19 #3437

Open
aldenquimby opened this issue Jan 15, 2025 · 3 comments
Open

[Feature]: Add support for React 19 #3437

aldenquimby opened this issue Jan 15, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@aldenquimby
Copy link

What's the feature?

React 19 is the latest stable major version. Quick starting new projects with React, Next.js, etc will give you React 19.

It would be nice if @100mslive/roomkit-react allowed using React 19, so that folks aren't forced to downgrade a major version to use 100ms.live

Related: #3131

@aldenquimby aldenquimby added the enhancement New feature or request label Jan 15, 2025
Copy link
Contributor

Hello! Thank you for filing an issue.

Please include relevant logs or detailed description for faster resolutions.

We really appreciate your contribution!

@raviteja83
Copy link
Collaborator

@aldenquimby are you facing any specific issues while using with React19 other than the peer dependecy errror?

@aldenquimby
Copy link
Author

aldenquimby commented Jan 27, 2025

@raviteja83 the only bug I've found so far is that virtual backgrounds do not work. The pane renders fine, but clicking a background does nothing, and this error is reported:
Image

There are lots of runtime errors in the console, but they don't appear to cause any actual problems. For example on loading PreviewScreen:

Image

Various other screens (e.g. settings modal from within conference screen) report the same ref runtime error, but appear to work fine.

From the conference screen participant list side panel, I see this runtime error, although all appears to work fine:
Image

(I did not test the whiteboard feature, because I haven't gotten that working with React 18 yet in Next.js)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants