Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to ensure DelayedEncodeData is serialized properly #216

Open
BellringerQuinn opened this issue Oct 25, 2024 · 0 comments
Open

Comments

@BellringerQuinn
Copy link
Collaborator

With the Unity SDK, we recently encountered errors related to DelayedEncodeData json serialization.

The DelayedEncodeData object allows you to include an object[], args. These args can be anything from ints to strings to complex objects with multiple fields to arrays. Any complex object must have their fields serialized alphabetically.

In the Unity SDK, we added this test https://github.com/0xsequence/sequence-unity/blob/master/Assets/SequenceSDK/WaaS/Tests/DelayedEncodeJsonSerializationTest.cs and modified the JSON serializer logic until it would pass the test.

This potential bug may pop up for clients who use complex contracts and can be hard to diagnose/identify. Let's add a test (and correct behaviour if necessary) for the Unreal SDK to avoid future headaches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant