Does Not Work on Workspace

[Metaxona]

i tried it on a foundry noir starter with a circuit workspace like this

circuits
├── a
│   ├── src
│   ├── Prover.toml
│   └── Nargo.toml
├── b
│   ├── src
│   ├── Prover.toml
│   └── Nargo.tomlext
└── Nargo.toml

and it isn't working since it is looking for a package.name in Nargo.toml in the workspace root.
that one doesn't exist normally unless you add it based on the noir docs on workspace,
and i added one and that worked, but another problem came up regarding the package.type which
i set to bin too but still no luck (lib, bin) won't work with this.

so basically this current helper only works on a non workspace circuit project like the one that comes with noir-starter/with-foundry
with a tree like this

circuits
├── src
├── Prover.toml
└── Nargo.toml

[0xnonso]

hi hi @Metaxona, you're right about foundry-noir-helper; i really didn't consider workspaces when designing the contract. could you please share your workspace or perhaps a minimal repro so I can take a look?

[Metaxona]

hi hi @Metaxona, you're right about foundry-noir-helper; i really didn't consider workspaces when designing the contract. could you please share your workspace or perhaps a minimal repro so I can take a look?

okay i will make a minimal reproduction later and add it here

[Metaxona]

hi hi @Metaxona, you're right about foundry-noir-helper; i really didn't consider workspaces when designing the contract. could you please share your workspace or perhaps a minimal repro so I can take a look?

made it https://github.com/Metaxona/noir-foundry-workspace

[0xnonso]

so currently, this issue can be fixed by specifying a custom circuit directory. i.e for the workspace this would look like noirHelper.withInput("x", 1).withInput("y", 5).withProjectPath("circuits/a").
and i also extended the the functionality to output the proof to a custom dir. which would also look like noirHelper.withInput("x", 1).withInput("y", 5).withProjectPath("circuits/a").withProofOutputPath("circuits/target/").

[0xnonso]

also created a pr Metaxona/noir-foundry-workspace#1

[Metaxona]

also created a pr Metaxona/noir-foundry-workspace#1

works now after i updated the foundry-noir-helper lib on my side, thanks a lot.