Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting response headers #24

Open
kurko opened this issue Jun 7, 2021 · 1 comment
Open

Getting response headers #24

kurko opened this issue Jun 7, 2021 · 1 comment

Comments

@kurko
Copy link

kurko commented Jun 7, 2021

With the current approach, all requests return only the response body, that is, a JSON that is converted into a hash. That means it's not possible to know information about rate limiting, cache and more.

Here's an example: https://github.com/Jakenberg/binance-ruby/blob/master/lib/binance/api/account.rb#L26-L28

Would there be interest to instead return the HTTP object and let the client call response.body, instead of prohibiting the client from accessing anything other than the HTTP body?

@0xjmp
Copy link
Owner

0xjmp commented Jan 9, 2022

Yeah that makes sense to me. If you'd like to put up a backwards compatible PR I'll review within a week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants