Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenZeppelin contracts to a version newer than 0.8.1 #352

Closed
mikiw opened this issue Feb 19, 2024 · 6 comments · Fixed by #695 · May be fixed by #493
Closed

Update OpenZeppelin contracts to a version newer than 0.8.1 #352

mikiw opened this issue Feb 19, 2024 · 6 comments · Fixed by #695 · May be fixed by #493
Labels
On hold waiting for more info or other features

Comments

@mikiw
Copy link
Contributor

mikiw commented Feb 19, 2024 •
edited
Loading

https://github.com/OpenZeppelin/cairo-contracts/blob/v0.9.0/src/token/erc20/erc20.cairo

remember about removing the #[key] keyword from the event in erc20 contracts so it is not indexed
(related to #356)
@mikiw mikiw self-assigned this Feb 19, 2024
@mikiw
Copy link
Contributor Author

mikiw commented Feb 21, 2024 •
edited
Loading

Seems that the current OZ wizard doesn't support the mintable feature for v0.9.0.

Due to this problem and the urgency of key attribute comments, this will need to be handled in 2 separate PRs.

Changing status to on hold.

@mikiw mikiw assigned mikiw and unassigned mikiw Feb 21, 2024
@mikiw mikiw added the On hold waiting for more info or other features label Feb 21, 2024
@FabijanC
Copy link
Contributor

Perhaps UDC can also be updated with this issue

@ivpavici
Copy link
Contributor

ivpavici commented Apr 8, 2024 •
edited
Loading

v0.11 came out in the meantime!

@FabijanC
Copy link
Contributor

FabijanC commented May 20, 2024 •
edited
Loading

v0.13 is out:
https://github.com/OpenZeppelin/cairo-contracts/releases/tag/v0.13.0

@mikiw mikiw linked a pull request Jun 14, 2024 that will close this issue
Update of contracts #493
Draft
10 tasks
@mikiw
Copy link
Contributor Author

mikiw commented Jun 19, 2024 •
edited by FabijanC
Loading

Seems that the update of UDC requires a version of starknet.rs that supports the selector "deploy_contract" (0.13.0 cairo1) instead of "deployContract" (0.5.0 cairo0)

https://github.com/xJonathanLEI/starknet-rs/blob/36ec1d681fc2917ca4857d14ce262ed7c2b60a7a/starknet-contract/src/factory.rs#L16

@FabijanC FabijanC mentioned this issue Feb 10, 2025
Draft
10 tasks
@FabijanC FabijanC changed the title Update OpenZeppelin contracts to 0.9.0 Update OpenZeppelin contracts to a version newer than 0.8.1 Feb 10, 2025
@FabijanC
Copy link
Contributor

FabijanC commented Feb 10, 2025 •
edited
Loading

As discussed here: https://spaceshard.slack.com/archives/C029F9AN8LX/p1738944026864319
We need an account contract implementation which doesn't use unwrap, but unwrap_syscall. One more reason to address this issue.

@FabijanC FabijanC mentioned this issue Feb 12, 2025
Merged
10 tasks
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in starknet-devnet-rs Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
On hold waiting for more info or other features
Projects
starknet-devnet-rs
Status: ✅ Done
Milestone
No milestone
3 participants
@ivpavici @mikiw @FabijanC