This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
feat: Graceful Shutdowns #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deploy staging |
|
deploy staging |
xianny
reviewed
Jul 13, 2020
xianny
approved these changes
Jul 13, 2020
dekz
approved these changes
Jul 20, 2020
Co-authored-by: Jacob Evans <[email protected]>
|
deploy staging |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 27, 2020
# [1.12.0](v1.11.0...v1.12.0) (2020-07-27) ### Bug Fixes * synchronization false unless tests ([#292](#292)) ([e050a22](e050a22)) ### Features * Curve BTC Bridge ([#294](#294)) ([82f9276](82f9276)) * Depth Chart API endpoint ([#290](#290)) ([540f92e](540f92e)) * Graceful Shutdowns ([#280](#280)) ([5736c74](5736c74)) * Update protocol fee to 70k. Yield to event loop in path optimizer ([#285](#285)) ([a996c7b](a996c7b))
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
createDefaultServerfunction to be used across all HTTP runners which prepares ahttp.Serverwith:server.keepAliveTimeout&server.headersTimeout/healthzrequestLogger,cors,bodyParserTesting Instructions
This PR has been tested on staging, however we can still unit test the graceful shutdown:
Checklist
[WIP]if necessary.