This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
feat: add transaction price information to meta-txn endpoints for UI #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekz
force-pushed
the
feat/estimated-fees-meta
branch
from
80ffdfc to
f11cd3e
Compare
dekz
force-pushed
the
feat/estimated-fees-meta
branch
from
f11cd3e to
c255b83
Compare
|
deploy staging |
dekz
force-pushed
the
feat/estimated-fees-meta
branch
from
a597cef to
7e4a0f9
Compare
dekz
force-pushed
the
feat/estimated-fees-meta
branch
from
7e4a0f9 to
0b13670
Compare
|
deploy staging |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 15, 2020
# [1.8.0](v1.7.0...v1.8.0) (2020-06-15) ### Bug Fixes * uniswap v2 buys ([#253](#253)) ([225db22](225db22)) ### Features * Add support for UniswapV2 and MultiBridge ([#250](#250)) ([29636e7](29636e7)), closes [#252](#252) * add transaction price information to meta-txn endpoints for UI ([#248](#248)) ([d26d6c6](d26d6c6))
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to communicate exactly how much money we're saving users in the meta-txn endpoint too. This is a bit different than the regular endpoint:
protocolFeeinstead ofminimumProtocolFee.Testing Instructions
Checklist
[WIP]if necessary.