Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the assertions to the beginning of function #537

Closed
Tracked by #547
vlopes11 opened this issue Nov 21, 2022 · 4 comments
Closed
Tracked by #547

Move the assertions to the beginning of function #537

vlopes11 opened this issue Nov 21, 2022 · 4 comments
Assignees
@MuhtasimTanmoy
Labels
assembly Related to Miden assembly good first issue Good for newcomers

Comments

@vlopes11
Copy link
Contributor

It is desirable to have assertions in the beginning of a function because the compiler might be able to improve its optimization, and it is more readable for the users to understand the panic conditions of a function

Originally posted by @bobbinth in #530 (comment)
@vlopes11 vlopes11 added the good first issue Good for newcomers label Nov 21, 2022
@bobbinth bobbinth added the assembly Related to Miden assembly label Nov 21, 2022
@bobbinth bobbinth mentioned this issue Nov 23, 2022
Closed
@0xPolygonMiden 0xPolygonMiden deleted a comment from ef3n9r98 Nov 30, 2022
@vlopes11 vlopes11 assigned vlopes11 and unassigned vlopes11 Dec 7, 2022
@MuhtasimTanmoy
Copy link
Contributor

I would like to work on this.

@bobbinth
Copy link
Contributor

Thank you! It is all yours!

@MuhtasimTanmoy MuhtasimTanmoy mentioned this issue Feb 20, 2023
Merged
@MuhtasimTanmoy
Copy link
Contributor

Please review PR #707

@bobbinth
Copy link
Contributor

Closed by #707.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MuhtasimTanmoy MuhtasimTanmoy

Labels
assembly Related to Miden assembly good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vlopes11 @MuhtasimTanmoy @bobbinth