Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MastForest: Ensure that the number of nodes is less than 2^30 #1392

Closed
plafer opened this issue Jul 12, 2024 · 2 comments
Closed

MastForest: Ensure that the number of nodes is less than 2^30 #1392

plafer opened this issue Jul 12, 2024 · 2 comments
Assignees
@sergerad
Labels
good first issue Good for newcomers

Comments

@plafer
Copy link
Contributor

plafer commented Jul 12, 2024

The serialization format of MastForest introduced in #1370 implicitly assumes that the internal value of a MastNodeId fits in 30 bits. Hence, MastForest should enforce this constraint.
@plafer plafer added the good first issue Good for newcomers label Jul 12, 2024
@plafer plafer mentioned this issue Jul 12, 2024
Merged
@sergerad
Copy link
Contributor

sergerad commented Jul 15, 2024 •
edited
Loading

@plafer I would like to have a crack.

I'm assuming adding impl TryFrom<u32> for MastNodeId { is appropriate.

This was referenced Jul 15, 2024
Closed
Merged
@bobbinth
Copy link
Contributor

Closed by #1394. Thank you again @sergerad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergerad sergerad

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@plafer @bobbinth @sergerad