Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impelement pending txs queue #723

Merged
merged 10 commits into from
Jun 9, 2022
Merged

impelement pending txs queue #723

merged 10 commits into from
Jun 9, 2022

Conversation

Mikelle
Copy link
Contributor

@Mikelle Mikelle commented Jun 8, 2022 •
edited
Loading

What does this PR do?

Closes #728
Implemented pending txs queue for sequencer v2

Reviewers

Main reviewers:

fgimenez
fgimenez reviewed Jun 8, 2022
View reviewed changes
Copy link
Contributor

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't started yet with the actual review, but shouldn't this be added to the new sequencerv2 package? Maybe we can just add there the config, the pendingtxqueue.go file and the test, and we can add later the skeleton, wdyt?

@Mikelle Mikelle self-assigned this Jun 8, 2022
@Mikelle
Copy link
Contributor Author

Mikelle commented Jun 8, 2022 •
edited
Loading

Haven't started yet with the actual review, but shouldn't this be added to the new sequencerv2 package? Maybe we can just add there the config, the pendingtxqueue.go file and the test, and we can add later the skeleton, wdyt?

I would like to add it to the new package in a new PR

fgimenez
fgimenez reviewed Jun 8, 2022
View reviewed changes
sequencer/pendingtxsqueue.go Outdated Show resolved Hide resolved
sequencer/pendingtxsqueue.go Outdated Show resolved Hide resolved
sequencer/pendingtxsqueue.go Outdated Show resolved Hide resolved
sequencer/pendingtxsqueue.go Outdated Show resolved Hide resolved
@fgimenez fgimenez mentioned this pull request Jun 9, 2022
Merged
@Mikelle Mikelle requested a review from fgimenez June 9, 2022 11:15
fgimenez
fgimenez approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mikelle Mikelle merged commit ad351b3 into develop Jun 9, 2022
@Mikelle Mikelle deleted the pending-txs-queue branch June 9, 2022 14:43
KonradIT added a commit that referenced this pull request Jun 10, 2022
@KonradIT
Squashed commit of the following:
6e37d4e 
commit 4b453a3
Author: Thiago Coimbra Lemos <[email protected]>
Date:   Thu Jun 9 13:49:01 2022 -0300

    Json rpc unit tests (#689)

commit 2591014
Author: Federico Gimenez <[email protected]>
Date:   Thu Jun 9 18:46:27 2022 +0200

    Initial consumer interfaces for sequencer v2 (#733)

    * Initial consumer interfaces for sequencer v2

    * add nolint

    * add state methhods from syncrhonizer and ProcessSequence

commit ad351b3
Author: Mikhail Wall <[email protected]>
Date:   Thu Jun 9 18:43:33 2022 +0400

    impelement pending txs queue (#723)

    * impelement pending txs queue

    * fixed lint errors

    * fixed lint errors

    * added concurrent map support for pending queue

    * fixed goimport

    * fixed goimport

    * deleted redundant ticker, clean up CleanPendTxsChan and KeepPendingTxsQueue func

    * fixed data race

    * clean up pendingtxsqueue.go

    * get rid of ConcurrentMap

commit 6baf7a4
Author: Federico Gimenez <[email protected]>
Date:   Thu Jun 9 10:41:20 2022 +0200

    Configurable network configuration (#702)

    * Allow importing all network config fields

    * Network config merge

    * fix custom network test

    * Test_CustomNetwork integrated as test case of TestLoadCustomNetworkConfig

    * Default value for --network-base is internaltestnet

commit b0d1fad
Author: Alonso Rodriguez <[email protected]>
Date:   Thu Jun 9 10:06:51 2022 +0200

    Feature/skeleton (#722)

    * etherman skeleton

    * synchronizer skeleton

    * linter

    * suggestions

commit b752d52
Author: Toni Ramírez <[email protected]>
Date:   Thu Jun 9 09:42:55 2022 +0200

    Fix revert reason message (#703)

    * Fix revert reason message

    * Fix revert reason message

    * fix

commit 7b61286
Author: Toni Ramírez <[email protected]>
Date:   Thu Jun 9 09:42:01 2022 +0200

    Get lastbatch from data base (#699)

    * Get lastbach from data base

    * Delete comment

commit f7a72f7
Author: Alonso Rodriguez <[email protected]>
Date:   Wed Jun 8 12:27:43 2022 +0200

    fix (#714)

commit c982a0a
Author: Federico Gimenez <[email protected]>
Date:   Wed Jun 8 10:44:32 2022 +0200

    Unify wait tx code (#713)

commit 03f7f72
Author: Alonso Rodriguez <[email protected]>
Date:   Tue Jun 7 15:39:53 2022 +0200

    this allow to reach the synced state sooner (#706)

commit 35a910d
Author: Federico Gimenez <[email protected]>
Date:   Tue Jun 7 09:19:52 2022 +0200

    Run e2e tests in parallel on CI (#678)

    * Run e2e tests in parallel on CI

    * make ci groups filtering more specific when running make test-full
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgimenez fgimenez fgimenez approved these changes

@arnaubennassar arnaubennassar Awaiting requested review from arnaubennassar

@tclemos tclemos Awaiting requested review from tclemos tclemos is a code owner

@ARR552 ARR552 Awaiting requested review from ARR552 ARR552 is a code owner

Assignees

@Mikelle Mikelle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement pending transaction queue
2 participants
@Mikelle @fgimenez