Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Ensure free claim txs can be executed #2014

Closed
arnaubennassar opened this issue Apr 13, 2023 · 0 comments · Fixed by #2039
Closed

Ensure free claim txs can be executed #2014

arnaubennassar opened this issue Apr 13, 2023 · 0 comments · Fixed by #2039
Assignees

Comments

@arnaubennassar
Copy link
Member

Rationale

Why should this feature exist?

Right now we only accept one free tx per claim. The free claim is marked as used the moment the tx is added into the pool. Before doing so the tx gets pre-executed to ensure that it will succeed, but for some reason some claims got stucked. Some ideas why this could happen:

  • Invalid nonce
  • The tx fails when the sequencer actually executes it

What are the use-cases?

Don't freeze free claims if something goes wrong

Implementation

  • Make sure the nonce is correct before marking the claim as used
  • Remove the claim used check from DB if the tx fails
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants