Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit timestamp resolution #2004

Closed
ToniRamirezM opened this issue Apr 11, 2023 · 0 comments · Fixed by #2007
Closed

Limit timestamp resolution #2004

ToniRamirezM opened this issue Apr 11, 2023 · 0 comments · Fixed by #2007
Assignees
Milestone

Comments

@ToniRamirezM
Copy link
Contributor

ToniRamirezM commented Apr 11, 2023

Rationale

Some dapps base its logic in the timestamp and we should update it at a max interval to be defined.

Implementation

When a new TX arrives if the batch timestamp is > than the max allowed, we must close the batch, create a new one and add this new TX to the new batch.

If it is the first tx in the batch, update the batch's timestamp to time.now()

Use a new config parameter: timestampResolution

Remove current parameter to close a batch due to a timeout.
Take into account this timestamp for gas estimation and eth_call: use time.Now() if block is not forced.

@ToniRamirezM ToniRamirezM self-assigned this Apr 11, 2023
@ToniRamirezM ToniRamirezM changed the title Limit timestamp lifetime Limit timestamp resolution Apr 11, 2023
@agnusmor agnusmor added this to the Release 0.1.0 milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants