Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Custom solidity errors (introduced in 0.8.4) not supported #1350

Closed
sebastiendan opened this issue Mar 31, 2023 · 3 comments · Fixed by #1566
Closed

Custom solidity errors (introduced in 0.8.4) not supported #1350

sebastiendan opened this issue Mar 31, 2023 · 3 comments · Fixed by #1566

Comments

@sebastiendan
Copy link

Custom solidity errors (introduced in solidity 0.8.4) not supported

Description

Hi,

I haven't been capable of receiving proper error data when interacting with some contracts deployed to Edge chains. These contracts leverage solidity >0.8.4 custom errors, used with revert in the revert MyError(myData) manner.

Thinking the problem was on the js client side, I jumped on an older ethers issue. Investigating with their team, it seems the problem is coming from Edge which is not returning the error data at all.

Please find the details of my setup at the very bottom of the issue on ethers:
ethers-io/ethers.js#1493

Your environment

  • macOS v13.2.1.
  • Edge v0.8.0.
  • Local docker setup with docker image built from /docker/local

Steps to reproduce

  • Run a polygon-edge chain
  • Deploy the contract provided here
  • Interact with the contract to trigger the revert
  • Notice that your js client (ethers or web3) is not parsing any information from the error (we only know that the call reverted)

Expected behavior

  • The explicit error should be returned
@sebastiendan
Copy link
Author

Any update here?

@dankostiuk
Copy link
Contributor

Any update @laviniat1996 ? Would be great to know whether or not edge can/will support custom errors in the near future, thanks!

@vcastellm
Copy link
Contributor

Update: We're working on this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants