Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: trait objects in EmbeddingsBuilder #62

Closed
marieaurore123 opened this issue Oct 16, 2024 · 1 comment
Closed

feat: trait objects in EmbeddingsBuilder #62

marieaurore123 opened this issue Oct 16, 2024 · 1 comment
Assignees
@marieaurore123
Milestone
v0.5

Comments

@marieaurore123
Copy link
Contributor

Feature Request

Use trait objects in the emebddings builder store.

Motivation

Allow objects of different types to be added to the embeddings builder, as long as they all implement Embeddable trait. This is especially useful for tools.
@marieaurore123 marieaurore123 self-assigned this Oct 16, 2024
@marieaurore123 marieaurore123 mentioned this issue Oct 16, 2024
Closed
14 tasks
@cvauclair
Copy link
Contributor

What would be the return type of EmbeddingsBuilder::build then?

@mateobelanger mateobelanger added this to the v0.5 milestone Nov 12, 2024
@mateobelanger mateobelanger closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marieaurore123 marieaurore123

Labels
None yet
Projects
None yet
Milestone
v0.5
Development

No branches or pull requests
3 participants
@cvauclair @mateobelanger @marieaurore123