Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(embeddings builder): improve multi-field embed functionality #60

Closed
marieaurore123 opened this issue Oct 16, 2024 · 0 comments
Closed
Assignees
Milestone

Comments

@marieaurore123
Copy link
Contributor

Feature Request

The Embeddable trait should account for the case where a struct contains multiple fields to embed.

Motivation

Currently, when there are multiple fields of a struct that need to be embedded, the Embeddable trait method fn embedabble() creates a list of strings for those fields and concatenates them together as a single list of strings. There is no way to differentiate between the strings from field A and the strings from field B.

If the goal of creating embeddings is to add them to a vector store afterwards, it may not be the desired effect to store the vector embeddings of multiple fields into a single field of the vector store.

Proposal

I don't know yet.

@marieaurore123 marieaurore123 self-assigned this Oct 16, 2024
@mateobelanger mateobelanger added this to the v0.5 milestone Nov 12, 2024
@mateobelanger mateobelanger closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants