ENG-4831 fix(portal): update image modal component to use graphql #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanprozzi
approved these changes
Nov 26, 2024
Vitalsine85
deleted the
vital/eng-4831-update-imagemodal-component-to-use-graphql
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Packages
Apps
Packages
Tools
Overview
Updates ImageModal to handle the props individually rather than passing the full atom object. While we may want to simplify this by passing the complete atom in the future, the current type mismatches between the GraphQL and legacy API make granular prop handling more maintainable.
Screen Captures
If applicable, add screenshots or screen captures of your changes.
Declaration