Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4562 feat(data-populator): prune env values - first pass #873

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

jonathanprozzi
Copy link
Member

Affected Packages

Apps

  • portal
  • data-populator

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

  • First pass of removing unused env vars and config/scaffolding from Data Populator. There are more that are duplicates that we can continue to remove but wanted to streamline this prior to initial testnet deployment. I can revisit after that to do another pass as part of some of our larger env/deployment strategy.
  • Ran through the flow and everything still works after these changes.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Oct 22, 2024

@github-actions github-actions bot added the chore Chore label Oct 22, 2024
@jonathanprozzi jonathanprozzi changed the title ENG-4562 chore(data-populator): prune env values - first pass ENG-4562 feat(data-populator): prune env values - first pass Oct 22, 2024
@jonathanprozzi jonathanprozzi added feat Feature and removed chore Chore labels Oct 22, 2024
@jonathanprozzi
Copy link
Member Author

jonathanprozzi commented Oct 22, 2024

Relabeled from chore to feat as core code/logic is touched

@jonathanprozzi jonathanprozzi enabled auto-merge (squash) October 22, 2024 17:29
@jonathanprozzi jonathanprozzi merged commit b7f7b4d into main Oct 22, 2024
6 checks passed
@jonathanprozzi jonathanprozzi deleted the eng-4562-prune-env-values branch October 22, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants