Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-0000 fix(portal): fix max button math #861

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

Vitalsine85
Copy link
Member

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

Reverted back to decimal math instead of big int math as it was causing issues, raising insufficient funds errors, due to the result having more than 18 decimals.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

@github-actions github-actions bot added the fix Fix label Oct 16, 2024
@Vitalsine85 Vitalsine85 enabled auto-merge (squash) October 16, 2024 22:11
@Vitalsine85 Vitalsine85 merged commit d353c55 into main Oct 16, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-0000-fix-max-button branch October 16, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants