Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4079 feat(portal): add share button modal detail pages #847

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

jonathanprozzi
Copy link
Member

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

  • Adds a ShareCta component that takes in the currentPath from where it's triggered and opens the ShareModal that renders a QR code + Copy link
  • Adds this to profile ($wallet), list, identity, and claim detail pages
  • Refinements noted for next ticket: Add QR code to 1ui (needs some scaling in Figma to work with our current Icon structure), feedback to user on the Copy Link, customization of the modal to note if on list/identity/claim/profile
    • @0xjojikun I figured we'd want to get this in and then iterate and refine in the next ticket

Screen Captures

share-qr-wip-2

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Sep 17, 2024

@github-actions github-actions bot added the feat Feature label Sep 17, 2024
@jonathanprozzi jonathanprozzi merged commit 47c9394 into main Sep 17, 2024
3 checks passed
@jonathanprozzi jonathanprozzi deleted the eng-4079-add-share-button-modal-detail-pages branch September 17, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants