Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3664 fix(portal): preserve searchParams on explore search #827

Merged

Conversation

Vitalsine85
Copy link
Member

@Vitalsine85 Vitalsine85 commented Sep 6, 2024

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

Previously, if a user had set the rows per page to anything besides the default of 10, after entering some text into the search bar on the Explore Identities route, it would update but only show the default 10 results. This fix preserves the searchParam for limit.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

PR Summary by Typo

Summary:
This pull request eliminates the usage of useSubmit from @remix-run/react and replaces it with useSearchParams. The search form input placeholder now defaults to "Search".

Key Points:

  1. Replaces useSubmit with useSearchParams for updating search parameters.
  2. Input placeholder in search form is set to a default value of "Search".
To turn off PR summary, please visit Notification settings.

Copy link

linear bot commented Sep 6, 2024

ENG-3664 Pagination Updates Break When Text Search

Description:

Lets say I change the page to view 50 rows. If I then do a text search, it changes back to 10 but still says 50.

Attachments:
-only shows 10. but set to 50 after text search bar is cleared

Screenshot 2024-08-21 at 15.47.57.png

@Vitalsine85 Vitalsine85 enabled auto-merge (squash) September 10, 2024 16:22
@Vitalsine85 Vitalsine85 merged commit 172543b into main Sep 10, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-3664-pagination-updates-break-when-text-search branch September 10, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants