Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3826 fix(portal): fix video overflow on create #813

Conversation

Vitalsine85
Copy link
Member

@Vitalsine85 Vitalsine85 commented Aug 30, 2024

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

The relic video after creating your user identity was still overflowing after the last fix. Forgot to apply the same styling to the parent containers which should constrain it to the size of the screen. You have to zoom in over 400% for it to overflow now, and it looks good on mobile. Should be good from here.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

PR Summary by Typo

Summary
This pull request modifies the layout of the Profile component in create.tsx.

Key Points

  1. Adjusted the height of the main content area and padding.
  2. Changed the inner div structure.

Layout adjustments

  • Min-height adjustment: Changed the height of the main content area from h-screen to min-h-screen.
  • Padding adjustment: Removed the fixed height for the padding in smaller screens (md:p-8).
  • Inner div structure: Changed the class of the inner div from flex justify-center items-center h-screen to flex-grow flex justify-center items-center.
To turn off PR summary, please visit Notification settings.

Copy link

linear bot commented Aug 30, 2024

ENG-3826 The first intro video was resized, but the second intro video was not

We previously resized the NFT videos so that they weren't too big for the screen, however it appears that only the first video was resized, and that the second video (after the user successfully uploads name and photo) was not resized.

Screenshot 2024-08-29 at 4.41.26 PM.png

@github-actions github-actions bot added the fix Fix label Aug 30, 2024
@Vitalsine85 Vitalsine85 enabled auto-merge (squash) August 30, 2024 15:22
@Vitalsine85 Vitalsine85 merged commit 3b1dec0 into main Aug 30, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-3826-the-first-intro-video-was-resized-but-the-second-intro-video branch August 30, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants