Skip to content

Commit

Permalink
sysvipc-unteach-ids-next_id-for-checkpoint_restore-checkpatch-fixes
Browse files Browse the repository at this point in the history
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
torvalds#14: 
03f5956 ("ipc: add sysctl to specify desired next object id"). 

WARNING: macros should not use a trailing semicolon
torvalds#75: FILE: ipc/util.c:224:
+#define ipc_idr_alloc(ids, new)						\
+	idr_alloc(&(ids)->ipcs_idr, (new),				\
+		  (ids)->next_id < 0 ? 0: ipcid_to_idx((ids)->next_id), \
+		  0, GFP_NOWAIT);

ERROR: spaces required around that ':' (ctx:VxW)
torvalds#77: FILE: ipc/util.c:226:
+		  (ids)->next_id < 0 ? 0: ipcid_to_idx((ids)->next_id), \
 		                        ^

WARNING: macros should not use a trailing semicolon
torvalds#96: FILE: ipc/util.c:245:
+#define ipc_idr_alloc(ids, new)					\
+	idr_alloc(&(ids)->ipcs_idr, (new), 0, 0, GFP_NOWAIT);

total: 2 errors, 2 warnings, 117 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/sysvipc-unteach-ids-next_id-for-checkpoint_restore.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Davidlohr Bueso <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
  • Loading branch information
akpm00 authored and hnaz committed Nov 3, 2017
1 parent ac2c812 commit 1823774
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions ipc/util.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,8 @@ int ipc_get_maxid(struct ipc_ids *ids)
*/
#define ipc_idr_alloc(ids, new) \
idr_alloc(&(ids)->ipcs_idr, (new), \
(ids)->next_id < 0 ? 0: ipcid_to_idx((ids)->next_id), \
0, GFP_NOWAIT);
(ids)->next_id < 0 ? 0 : ipcid_to_idx((ids)->next_id),\
0, GFP_NOWAIT)

static inline int ipc_buildid(int id, struct ipc_ids *ids,
struct kern_ipc_perm *new)
Expand All @@ -244,7 +244,7 @@ static inline int ipc_buildid(int id, struct ipc_ids *ids,

#else
#define ipc_idr_alloc(ids, new) \
idr_alloc(&(ids)->ipcs_idr, (new), 0, 0, GFP_NOWAIT);
idr_alloc(&(ids)->ipcs_idr, (new), 0, 0, GFP_NOWAIT)

static inline int ipc_buildid(int id, struct ipc_ids *ids,
struct kern_ipc_perm *new)
Expand Down

0 comments on commit 1823774

Please sign in to comment.