Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): fixed filepath.Dir and file.IsAbs issue on windows #379

Merged
merged 7 commits into from
Mar 16, 2023

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Mar 8, 2023

Changes

Fixes

  • fixed filepath.Dir and path.IsAbs issue on windows.

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

Copy link

@ranajahanzaib ranajahanzaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @cnlangzi 👍

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped ABILITY TO SKIP TESTS IS DISABLED. SKIP_TESTS OPTION IGNORED.
system-tests master
gosdk fix/path_dir_issue_on_win
zboxcli fix/path_dir_issue_on_win
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped ABILITY TO SKIP TESTS IS DISABLED. SKIP_TESTS OPTION IGNORED.
system-tests master
gosdk fix/path_dir_issue_on_win
zboxcli fix/path_dir_issue_on_win
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi merged commit f5a557b into staging Mar 16, 2023
@cnlangzi cnlangzi deleted the fix/path_dir_issue_on_win branch March 16, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants