Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js throws exception when Process.destroy called on Windows #108

Closed
05nelsonm opened this issue Jun 15, 2024 · 4 comments · Fixed by #111
Closed

Node.js throws exception when Process.destroy called on Windows #108

05nelsonm opened this issue Jun 15, 2024 · 4 comments · Fixed by #111
Labels
bug Something isn't working

Comments

@05nelsonm
Copy link
Owner

05nelsonm commented Jun 15, 2024 •
edited
Loading

See https://github.com/05nelsonm/kmp-tor/actions/runs/9531067979/job/26272143682?pr=452#step:12:2057
@05nelsonm 05nelsonm added the bug Something isn't working label Jun 15, 2024
@05nelsonm
Copy link
Owner Author

05nelsonm commented Jun 16, 2024 •
edited
Loading

The error code is EPERM and is attributed to the child_process.kill function. Only happening on Windows for me in kmp-tor.

See: nodejs/node#51766

@05nelsonm 05nelsonm changed the title Node.js crashes when process error event emitted Node.js throws exception when Process.destroy called Jun 16, 2024
@05nelsonm 05nelsonm changed the title Node.js throws exception when Process.destroy called Node.js throws exception when Process.destroy called on Windows Jun 16, 2024
@05nelsonm
Copy link
Owner Author

05nelsonm commented Jun 16, 2024 •
edited
Loading

Node.js version was updated from 20.10.0 to 22.0.0 which landed in kotlin 1.9.24

https://youtrack.jetbrains.com/issue/KT-67785

https://github.com/JetBrains/kotlin/releases/tag/v1.9.24

JetBrains/kotlin@29b1b65

@05nelsonm
Copy link
Owner Author

Node.js bug introduced in 21.6.2 when libuv updated from 1.47.0 to 1.48.0 in santigimeno/node@4207227#diff-b6629d4d9568adae6c40988e419be1c588fb033c2d93b4fecfb3082fb3712cc6

The "potential fix" hasn't landed yet.

@05nelsonm
Copy link
Owner Author

Error in libuv introduced in libuv/libuv@129362f

@05nelsonm 05nelsonm mentioned this issue Jun 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bad windows libuv 1.48.0 implementation for Node.js 05nelsonm/kmp-process
1 participant
@05nelsonm