Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Exposing spectral random seed property #193

Merged
merged 2 commits into from
Apr 1, 2021
Merged

[REVIEW] Exposing spectral random seed property #193

merged 2 commits into from
Apr 1, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Apr 1, 2021

No description provided.

@cjnolet cjnolet requested a review from divyegala as a code owner April 1, 2021 15:33
@github-actions github-actions bot added the cpp label Apr 1, 2021
@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Apr 1, 2021
@cjnolet cjnolet mentioned this pull request Apr 1, 2021
Merged
@cjnolet
Copy link
Member Author

cjnolet commented Apr 1, 2021

rerun tests

dantegd
dantegd approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

divyegala
divyegala approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member Author

cjnolet commented Apr 1, 2021

@gpucibot merge

@dantegd
Copy link
Member

dantegd commented Apr 1, 2021

rerun tests

@rapids-bot rapids-bot bot merged commit 91844e2 into rapidsai:branch-0.19 Apr 1, 2021
dantegd pushed a commit to dantegd/raft that referenced this pull request Jul 23, 2024
@jameslamb
fix library name in docs ('cuvs' not 'pycuvs') (rapidsai#193)
ebfd068 
The Python library is distributed as conda package `cuvs`, but the installation docs say `pycuvs`. This fixes that.

Looked for other uses like this:

```shell
git grep -i pycuvs
```

Didn't find any.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai/cuvs#193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjnolet @dantegd @divyegala