Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass pre-computed colors to MST #154

Merged
merged 4 commits into from
Mar 4, 2021
Merged

Pass pre-computed colors to MST #154

merged 4 commits into from
Mar 4, 2021

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented Feb 17, 2021 •
edited
Loading

closes #145

@cjnolet
Copy link
Member

cjnolet commented Feb 22, 2021

@divyegala is this PR also going to close #145 ?

@github-actions github-actions bot added the cpp label Mar 4, 2021
@divyegala divyegala added 3 - Ready for Review enhancement New feature or request non-breaking Non-breaking change labels Mar 4, 2021
@divyegala divyegala added the improvement Improvement / enhancement to an existing function label Mar 4, 2021
cjnolet
cjnolet approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Mar 4, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5b2240c into rapidsai:branch-0.19 Mar 4, 2021
dantegd pushed a commit to dantegd/raft that referenced this pull request Jul 23, 2024
@lowener
Add refine to public API (rapidsai#154)
b9e8a4b 
Add `cuvs::neighbors::refine` to public API, with it's test

Authors:
  - Micka (https://github.com/lowener)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Tamas Bela Feher (https://github.com/tfeher)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai/cuvs#154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review cpp enhancement New feature or request improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test color array in MST
2 participants
@divyegala @cjnolet