Rework libcuspatial CMakeLists.txt to export targets for CPM #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
added
3 - Ready for Review
…:cudftestutil is built
kkraus14
reviewed
Mar 3, 2021
trxcllnt
added
5 - DO NOT MERGE
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Mar 29, 2021
This PR ensures all `cudf::*` library aliases are created and promoted to `IMPORTED_GLOBAL` when `find_package(cudf)` finds cudf in a local build directory. ~This PR shouldn't affect CI or the targets you'd see when `libcudf` is installed (e.g. by conda), only local source builds.~ edit: This now fixes `cudf::*` alias targets for the `libcudf` installations too, needed by rapidsai/cuspatial#365. Validation method: ```shell $ docker run --rm -it \ -w /tmp/findpackagecudf \ -v "/tmp/findpackagecudf:/tmp/findpackagecudf" \ gpuci/miniconda-cuda:10.2-devel-ubuntu18.04 bash # Set up mamba environment conda install -y -n base -c conda-forge mamba mamba update -y -n base -c defaults conda && mamba update -y -n base -c conda-forge mamba mamba install -y -n base -c conda-forge -c rapidsai-nightly \ git gtest gmock ninja cmake=3.18 gdal=3.0.2 boost-cpp=1.72.0 cudatoolkit=10.2 libcudf=0.19 # Copy changes in this PR (from the host) to container's /opt/conda/lib/cmake/cudf # cmake --install $CUDF_ROOT --prefix $CUDF_ROOT/local-install # docker cp $CUDF_ROOT/local-install/lib/cmake/cudf frosty_agnesi:/opt/conda/lib/cmake/ # Clone cuspatial git clone https://github.com/trxcllnt/cuspatial.git && cd cuspatial && git checkout fix/cmake-exports # Configure cuspatial rm -rf cpp/build && mkdir -p cpp/build \ && cmake -GNinja -B cpp/build -S cpp \ -DBUILD_TESTS=ON -DBUILD_BENCHMARKS=ON -DCMAKE_CUDA_ARCHITECTURES= ``` Authors: - Paul Taylor (@trxcllnt) - Robert Maynard (@robertmaynard) Approvers: - Robert Maynard (@robertmaynard) - Keith Kraus (@kkraus14) - Ray Douglass (@raydouglass) URL: #7734
kkraus14
reviewed
Mar 29, 2021
kkraus14
reviewed
Mar 29, 2021
harrism
requested changes
Mar 30, 2021
Comment on lines
+52
to
+56
| virtual void SetUp(const ::benchmark::State& state) override | ||
| { | ||
| mr = std::make_shared<rmm::mr::cuda_memory_resource>(); | ||
| rmm::mr::set_current_device_resource(mr.get()); // set default resource to cuda | ||
| } |
There was a problem hiding this comment.
Why is this needed? The default resource is the cuda_memory_resource.
There was a problem hiding this comment.
The benchmark base class instantiates an RMM pool resource in the SetUp function. It's assigned to a local variable instead of the member var, so it segfaults. When I fix that, I get "Maximum pool size exceeded" on the first bench run.
I'm not sure why the second error is happening, and this PR is primarily about CMake. So this change just makes the benchmark code compile and run without crashing.
harrism
approved these changes
Mar 30, 2021
kkraus14
approved these changes
Mar 30, 2021
kkraus14
removed
5 - DO NOT MERGE
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes many of the same changes as were made in cudf/pull/7107.
cuspatial::cuspatialCMake alias targets.CPMFindPackageto findlibcudfinstalled on the system or buildlibcudffrom source.edit: Depends on rapidsai/cudf#7574 and rapidsai/cudf#7734