Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix min_max_axis #3735

Merged
merged 29 commits into from
Apr 12, 2021
Merged

[REVIEW] Fix min_max_axis #3735

merged 29 commits into from
Apr 12, 2021

Conversation

viclafargue
Copy link
Contributor

@viclafargue viclafargue commented Apr 9, 2021 •
edited by dantegd
Loading

Closes #3733

cjnolet and others added 19 commits April 1, 2021 11:52
@cjnolet
Fixing umap gtest failure under cuda 11.2.
d317121
@cjnolet
Fixing style
652ed6e
@cjnolet
Removing unecessry cinlude and device vector
68a5669
@cjnolet
Updating raft hash
d79cec4
@cjnolet
Merge branch 'branch-0.19' into bug-019-cuda_112_umap_gtest_failure
16cc5d7
@cjnolet
Updating raft hash
3bf9dc2
@cjnolet
Fixing doxygen issue
a16fd3f
@cjnolet
Updating raft hash
8a9009a
@cjnolet
Merge branch 'branch-0.19' into bug-019-cuda_112_umap_gtest_failure
a897be5
@cjnolet
Making init for umap mnmg test random
c8009a3
@cjnolet
Updating copyright
15808d0
@cjnolet
Printing random init results to test cuda 10.2
bc7abb5
@cjnolet
Updating raft hash
b2e05f9
@cjnolet
Merge branch 'branch-0.19' into bug-019-cuda_112_umap_gtest_failure
ba366aa
@cjnolet
Fixing style
dbc509f
@cjnolet
Using random init for umap test in 11.2+ and spectral for less than 1…
ae95b1a 
…1.2.
@cjnolet
Merge branch 'branch-0.19' into bug-019-cuda_112_umap_gtest_failure
98aba9c 
Conflicts:
	cpp/cmake/Dependencies.cmake
@cjnolet
Removing unecessary print
2f489da
@viclafargue
Fix min_max_axis
28563cc
@viclafargue viclafargue requested a review from a team as a code owner April 9, 2021 12:45
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Apr 9, 2021
@viclafargue viclafargue added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Apr 9, 2021
@viclafargue
Copy link
Contributor Author

rerun tests

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Apr 12, 2021
@viclafargue viclafargue requested a review from a team as a code owner April 12, 2021 13:40
JohnZed
JohnZed requested changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tiny changes

python/cuml/_thirdparty/sklearn/utils/sparsefuncs.py Outdated Show resolved Hide resolved
python/cuml/_thirdparty/sklearn/utils/sparsefuncs.py Outdated Show resolved Hide resolved
lowener
lowener approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@lowener lowener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnZed
Copy link
Contributor

JohnZed commented Apr 12, 2021

@rapidsai/ops-codeowners Ok to merge this as a fix for 0.19? The code changes are very small (one conditional cuda 11.2 change and a small preprocessing fix) but it also includes fixes to a few tests that will help clean up flakiness observed in 0.19 tests.

@cjnolet cjnolet mentioned this pull request Apr 12, 2021
Closed
@raydouglass
Copy link
Member

Ok to merge this as a fix for 0.19?

Yes. I will merge it.

@raydouglass raydouglass merged commit ef78253 into rapidsai:branch-0.19 Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnZed JohnZed JohnZed approved these changes

@lowener lowener lowener approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] test_thirdparty::test_min_max_axis pytest failure in CI
5 participants
@viclafargue @JohnZed @raydouglass @lowener @cjnolet