Upgrade to Treelite 1.1.0 #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
commented
Apr 3, 2021
hcho3
added
breaking
|
Rerun tests |
1 similar comment
|
Rerun tests |
hcho3
commented
Apr 5, 2021
JohnZed
reviewed
Apr 5, 2021
|
rapidsai/integration#240 is now merged, so updating this PR one last time. |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3708 +/- ##
===============================================
+ Coverage 80.70% 82.92% +2.21%
===============================================
Files 227 227
Lines 17615 17591 -24
===============================================
+ Hits 14217 14587 +370
+ Misses 3398 3004 -394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JohnZed
approved these changes
Apr 5, 2021
|
@gpucibot merge |
raydouglass
approved these changes
Apr 6, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks #3699, as the current version of Treelite (1.0.0) cannot handle model JSON files generated by XGBoost 1.4.0. The new Treelite release has the following improvements:
I'll also file a pull request to
integration.