-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the size of the cuml libraries #3702
Reduce the size of the cuml libraries #3702
Conversation
By explicitly telling nvcc's fatbin pass to always compress device code we can ensure that our binaries are the smallest possible size. See rapidsai/cudf#7583 for additional context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, it seems that only updating the copyright year in the cpp/CMakeLists.txt file is missing
What should it be 2019-2021? |
On second read it looks like the copyright failure is coming from :
Which I didn't touch. |
The copyright checker seems to have gone crazy in a few PRs (I should've checked the year in the cmakelists file..), checking what's the issue |
rerun tests |
On another PR, rerunning seemed to fix the copyright checker (which was picking up unchanged files) |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, how much did you save?
Never mind, I saw the impressive number on the linked issue. |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3702 +/- ##
===============================================
+ Coverage 80.70% 82.94% +2.23%
===============================================
Files 227 227
Lines 17615 17726 +111
===============================================
+ Hits 14217 14702 +485
+ Misses 3398 3024 -374
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@gpucibot merge |
By explicitly telling nvcc's fatbin pass to always compress device code we can ensure that our binaries are the smallest possible size.
See rapidsai/cudf#7583 for additional context.