Update to XGBoost 1.4.0rc1 #3699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
requested changes
Apr 1, 2021
There was a problem hiding this comment.
The integration version below will need to be updated before this PR can be approved.
https://github.com/rapidsai/integration/blob/branch-0.19/conda/recipes/versions.yaml#L9-L12
|
rerun tests |
|
Just filed rapidsai/integration#236 |
|
Blocked by dmlc/treelite#259 |
|
Depends on #3708 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 6, 2021
This unblocks #3699, as the current version of Treelite (1.0.0) cannot handle model JSON files generated by XGBoost 1.4.0. The new Treelite release has the following improvements: * Support JSON model files from XGBoost 1.4.0 * Support DART models I'll also file a pull request to `integration`. Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - John Zedlewski (https://github.com/JohnZed) - Ray Douglass (https://github.com/raydouglass) URL: #3708
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3699 +/- ##
===============================================
+ Coverage 80.70% 83.02% +2.31%
===============================================
Files 227 227
Lines 17615 17712 +97
===============================================
+ Hits 14217 14706 +489
+ Misses 3398 3006 -392
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JohnZed
approved these changes
Apr 6, 2021
|
@gpucibot merge |
ajschmidt8
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3695