-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SilhouetteScore C++ tests seed #3640
SilhouetteScore C++ tests seed #3640
Conversation
@divyegala since this is not for merging, can you change this to a draft PR? |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3640 +/- ##
===============================================
+ Coverage 80.70% 81.20% +0.49%
===============================================
Files 227 228 +1
Lines 17615 17869 +254
===============================================
+ Hits 14217 14511 +294
+ Misses 3398 3358 -40
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@dantegd can you review? |
@gpucibot merge |
As @hcho3 noted, a BatchedSilhouetteScore C++ test failed in CI with flakiness. Setting the seed ensures this won't happen