Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Adding make_pipeline + test score with pipeline #3632

Merged
merged 4 commits into from
Mar 24, 2021

Conversation

viclafargue
Copy link
Contributor

This PR adds the make_pipeline utility function. Additionally, it tests the score function on Pipeline with different cuML estimators.

@viclafargue viclafargue requested a review from a team as a code owner March 18, 2021 18:05
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 18, 2021
@viclafargue viclafargue added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 18, 2021
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@viclafargue viclafargue requested a review from a team as a code owner March 23, 2021 13:36
@viclafargue viclafargue added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Mar 23, 2021
@JohnZed
Copy link
Contributor

JohnZed commented Mar 23, 2021

rerun tests

1 similar comment
@JohnZed
Copy link
Contributor

JohnZed commented Mar 24, 2021

rerun tests

@codecov-io
Copy link

Codecov Report

Merging #3632 (6ee545c) into branch-0.19 (14bd6c1) will decrease coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3632      +/-   ##
===============================================
- Coverage        80.72%   80.44%   -0.29%     
===============================================
  Files              228      228              
  Lines            17629    17942     +313     
===============================================
+ Hits             14231    14433     +202     
- Misses            3398     3509     +111     
Flag Coverage Δ
dask 45.01% <0.00%> (+0.05%) ⬆️
non-dask 73.40% <100.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/pipeline/__init__.py 100.00% <100.00%> (ø)
python/cuml/linear_model/logistic_regression.pyx 59.69% <0.00%> (-29.27%) ⬇️
python/cuml/solvers/qn.pyx 70.96% <0.00%> (-26.67%) ⬇️
python/cuml/fil/fil.pyx 91.83% <0.00%> (ø)
python/cuml/dask/solvers/cd.py 100.00% <0.00%> (ø)
python/cuml/common/numba_utils.py 0.00% <0.00%> (ø)
python/cuml/neighbors/__init__.py 100.00% <0.00%> (ø)
python/cuml/internals/global_settings.py 100.00% <0.00%> (ø)
python/cuml/dask/preprocessing/encoders.py 100.00% <0.00%> (ø)
python/cuml/metrics/_ranking.py 98.57% <0.00%> (+0.02%) ⬆️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14bd6c1...6ee545c. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Mar 24, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9a2bd0c into rapidsai:branch-0.19 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants