Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update One-Hot Encoder doc #3600

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Mar 10, 2021

Closes #3598.

@lowener lowener requested a review from a team as a code owner March 10, 2021 14:39
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 10, 2021
@lowener lowener added 3 - Ready for Review Ready for review by team doc Documentation Cython / Python Cython or Python issue non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Mar 10, 2021
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dantegd
Copy link
Member

dantegd commented Mar 10, 2021

@gpucibot merge

@JohnZed
Copy link
Contributor

JohnZed commented Mar 11, 2021

Observed failure: ```
assert 0.7248901720406369 >= 0.99

  • where 0.7248901720406369 = adjusted_rand_score(array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,... 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,\n 2, 2, 2, 2, 2, 2, 2, 2, 2, 2], dtype=int32), array([0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0.,\n 0., 0., 0., 0., 0., 0., 0., 0., 0., ...., 4., 4., 4., 4., 4., 4., 4., 4.,\n 4., 4., 4., 4., 4., 4., 4., 4., 4., 4., 4., 4., 4., 4.],\n dtype=float32))
  • where array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,... 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,\n 2, 2, 2, 2, 2, 2, 2, 2, 2, 2], dtype=int32) = <function asnumpy at 0x7fa09c796700>(array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,... 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,\n 2, 2, 2, 2, 2, 2, 2, 2, 2, 2], dtype=int32))
  •  where <function asnumpy at 0x7fa09c796700> = cp.asnumpy
    
  • and array([0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0.,\n 0., 0., 0., 0., 0., 0., 0., 0., 0., ...., 4., 4., 4., 4., 4., 4., 4., 4.,\n 4., 4., 4., 4., 4., 4., 4., 4., 4., 4., 4., 4., 4., 4.],\n dtype=float32) = <function asnumpy at 0x7fa09c796700>(array([0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0.,\n 0., 0., 0., 0., 0., 0., 0., 0., 0., ...., 4., 4., 4., 4., 4., 4., 4., 4.,\n 4., 4., 4., 4., 4., 4., 4., 4., 4., 4., 4., 4., 4., 4.],\n dtype=float32))
  •  where <function asnumpy at 0x7fa09c796700> = cp.asnumpy
    
https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=gpu-a100,OS=ubuntu18.04,PYTHON=3.8/764/testReport/junit/cuml.test/test_kmeans/test_kmeans_clusters_blobs_1_0_5_25_1000_/

@JohnZed
Copy link
Contributor

JohnZed commented Mar 11, 2021

rerun tests

@codecov-io
Copy link

Codecov Report

Merging #3600 (7c8ac1b) into branch-0.19 (fd9ec89) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3600      +/-   ##
===============================================
+ Coverage        80.70%   80.83%   +0.12%     
===============================================
  Files              227      227              
  Lines            17615    17737     +122     
===============================================
+ Hits             14217    14337     +120     
- Misses            3398     3400       +2     
Flag Coverage Δ
dask 45.30% <ø> (+0.31%) ⬆️
non-dask 73.09% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/preprocessing/encoders.py 95.10% <ø> (+0.02%) ⬆️
python/cuml/cluster/kmeans.pyx 91.95% <0.00%> (ø)
python/cuml/dask/solvers/cd.py 100.00% <0.00%> (ø)
python/cuml/common/numba_utils.py 0.00% <0.00%> (ø)
python/cuml/internals/global_settings.py 100.00% <0.00%> (ø)
python/cuml/dask/preprocessing/encoders.py 100.00% <0.00%> (ø)
python/cuml/metrics/_ranking.py 98.57% <0.00%> (+0.02%) ⬆️
python/cuml/common/array_descriptor.py 98.24% <0.00%> (+0.03%) ⬆️
python/cuml/common/array.py 96.99% <0.00%> (+0.04%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd220fc...7c8ac1b. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 4aaec3b into rapidsai:branch-0.19 Mar 11, 2021
@lowener lowener deleted the 019-doc-onehot branch March 14, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Doc for OneHotEncoder's sparse says it's False by default but it's actually True by default
4 participants