-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade FAISS to 1.7.x #3509
Upgrade FAISS to 1.7.x #3509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version in the conda recipe
cuml/conda/recipes/libcuml/meta.yaml
Line 43 in befdf98
- libfaiss=1.6.3 |
Also we need a PR to the integration repo to update the version: https://github.com/rapidsai/integration, though before that pehaps it would be a good idea to use the ci/gpu/build.sh script
Line 62 in befdf98
# gpuci_conda_retry remove --force rapids-build-env rapids-notebook-env |
@viclafargue can you change this to target 0.19? |
Co-authored-by: Dante Gama Dessavre <[email protected]>
rerun tests |
For some reason, with CUDA 11, conda installs libfaiss 1.6.3. There seems to be a conflict with the ucx/ucx-py packages. |
It doesn't look like there should be any conflict. The installation works on my machine. I'll rerun the tests. |
rerun tests |
@gpucibot merge |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3509 +/- ##
================================================
- Coverage 80.69% 45.30% -35.39%
================================================
Files 227 223 -4
Lines 17615 17045 -570
================================================
- Hits 14214 7722 -6492
- Misses 3401 9323 +5922
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Answers #3459