Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bunch of bug fixes and features #398

Closed
wants to merge 77 commits into from
Closed

Conversation

j1c
Copy link
Contributor

@j1c j1c commented Sep 28, 2020

  1. ArgumentParser import is missing in m2g_dwi_pipeline, causing an error in case someone wants to run dwi_pipeline separately
  2. fix variable used before assignment error in plot_overlays
  3. fix default file names for mask files in DmriReg
  4. add proper file checking for gen_tissue output when using --skipreg
  5. Limit fury version. Latest versions do not work due to deprecations. Limited to the version in m2g:latest docker image.
  • Just disabled this code entirely as its causing issues when not in docker. Its broken and and kills the process.
  1. black on some files
  2. add check for parcellations. too many times i ran pipeline runs but realized there were no parcellations to begin with. maybe add a list of valid parcellations.
  3. add multiprocessing to connectome generation. there were lots of inefficiencies to begin with. this reduces time by A LOT.
  4. Moved the argument parsing outside of main() in m2g_bids.py so that arguments can be passed when not called as a script, but imported in different package.
  5. Parallelized tracking via splitting the seeds into chunks. This is simply a parallelization of a for loop. Proof here: notebook

Lawreros and others added 30 commits February 24, 2020 18:01
* necessary changes to allow large parcellations to run

* typo fix

* typo fix

* allow multiple parcellations to be run

* add csv import

* version lock cpac
@j1c j1c changed the title [WIP] Bunch of bug fixes [WIP] Bunch of bug fixes and features Sep 30, 2020
@j1c j1c mentioned this pull request Sep 30, 2020
2 tasks
@j1c j1c marked this pull request as ready for review October 7, 2020 17:33
@Lawreros
Copy link
Collaborator

I've merged your changes with the branch I've been working on cpac-py3, currently going through test to make sure everything runs ok. I think I may have accidentally changed your branch as well as a result of correcting the commit conflicts, so feel free to undo that commit

@Lawreros Lawreros closed this Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants