chore(config): remove ability to disable insights #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove `kuma.metrics.dataplane.enabled` and `kuma.metrics.zone.enabled` as insights are required internally anyway. Fix kumahq#2565 BREAKING CHANGE: it's now impossible to disable insights and the related configuration was removed Signed-off-by: Charly Molter <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3501 +/- ##
==========================================
- Coverage 51.67% 51.66% -0.02%
==========================================
Files 916 916
Lines 55350 55342 -8
==========================================
- Hits 28603 28591 -12
- Misses 24460 24473 +13
+ Partials 2287 2278 -9
Continue to review full report at Codecov.
|
jpeach
reviewed
Dec 13, 2021
jpeach
approved these changes
Dec 13, 2021
Signed-off-by: Charly Molter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
remove
kuma.metrics.dataplane.enabledandkuma.metrics.zone.enabledas insights are required internally anyway.Issues resolved
Fix #2565
Documentation
Testing
[ ] E2E tests[ ] Manual testing on Universal[ ] Manual testing on KubernetesBackwards compatibility
UPGRADE.mdwith any steps users will need to takewhen upgrading.
[x] AddBREAKING CHANGE: it's now impossible to disable insights and the related configuration was removedbackport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.