-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kuma-prometheus-sd) add deprecation notice #2994
Conversation
d840cd1
to
e796df3
Compare
This looks fine to me. @lahabana |
Codecov Report
@@ Coverage Diff @@
## master #2994 +/- ##
==========================================
+ Coverage 52.27% 52.33% +0.06%
==========================================
Files 919 919
Lines 53000 53007 +7
==========================================
+ Hits 27705 27742 +37
+ Misses 23087 23055 -32
- Partials 2208 2210 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense indeed!
Signed-off-by: austin ce <[email protected]>
e796df3
to
df8c849
Compare
Signed-off-by: austin ce <[email protected]> (cherry picked from commit 76ddf99)
Signed-off-by: austin ce <[email protected]> (cherry picked from commit 76ddf99) Co-authored-by: Austin Cawley-Edwards <[email protected]>
Signed-off-by: austin ce [email protected]
Summary
Having multiple SD mechanisms is causing confusion (see slack thread).
This starts the process of deprecating and removing the old
kuma-prometheus-sd
adapter.Full changelog
kuma-prometheus-sd
Issues resolved
Fix #2852
Documentation
Testing
Backwards compatibility
backport-to-stable
label if the code is backwards compatible. Otherwise, list breaking changes.Could break people's scripts if they are relying on the stdout of
kuma-prometheus-sd
anywhere, but that seems unlikely / not a true public interface.