Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-prometheus-sd) add deprecation notice #2994

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

austince
Copy link
Contributor

@austince austince commented Oct 22, 2021

Signed-off-by: austin ce [email protected]

Summary

Having multiple SD mechanisms is causing confusion (see slack thread).
This starts the process of deprecating and removing the old kuma-prometheus-sd adapter.

Full changelog

  • Add deprecation log message to kuma-prometheus-sd

Issues resolved

Fix #2852

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.
    Could break people's scripts if they are relying on the stdout of kuma-prometheus-sd anywhere, but that seems unlikely / not a true public interface.

@austince austince requested a review from a team as a code owner October 22, 2021 17:07
@austince austince force-pushed the feat/soft-deprecate-kuma-prometheus-sd branch from d840cd1 to e796df3 Compare October 22, 2021 20:13
@jpeach
Copy link
Contributor

jpeach commented Oct 24, 2021

This looks fine to me. @lahabana

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2021

Codecov Report

Merging #2994 (df8c849) into master (09a229c) will increase coverage by 0.06%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2994      +/-   ##
==========================================
+ Coverage   52.27%   52.33%   +0.06%     
==========================================
  Files         919      919              
  Lines       53000    53007       +7     
==========================================
+ Hits        27705    27742      +37     
+ Misses      23087    23055      -32     
- Partials     2208     2210       +2     
Impacted Files Coverage Δ
app/kuma-prometheus-sd/cmd/root.go 54.34% <55.55%> (-2.07%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 82.75% <0.00%> (-1.15%) ⬇️
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/dns/vips_allocator.go 74.00% <0.00%> (+1.33%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/insights/resyncer.go 69.75% <0.00%> (+2.74%) ⬆️
pkg/events/eventbus.go 92.59% <0.00%> (+7.40%) ⬆️
pkg/xds/cache/once/cache.go 94.87% <0.00%> (+7.69%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️
pkg/plugins/runtime/gateway/route/sorter.go 71.79% <0.00%> (+10.25%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a229c...df8c849. Read the comment docs.

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense indeed!

@austince austince force-pushed the feat/soft-deprecate-kuma-prometheus-sd branch from e796df3 to df8c849 Compare October 29, 2021 18:27
@austince austince merged commit 76ddf99 into master Oct 29, 2021
@austince austince deleted the feat/soft-deprecate-kuma-prometheus-sd branch October 29, 2021 19:06
mergify bot pushed a commit that referenced this pull request Oct 29, 2021
Signed-off-by: austin ce <[email protected]>
(cherry picked from commit 76ddf99)
austince added a commit that referenced this pull request Oct 29, 2021
Signed-off-by: austin ce <[email protected]>
(cherry picked from commit 76ddf99)

Co-authored-by: Austin Cawley-Edwards <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log deprecation warning in kuma-prometheus-sd
4 participants