feat(kuma-cp) change KDS max message limit #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Jul 1, 2021
Signed-off-by: Jakub Dyszkiewicz <[email protected]> (cherry picked from commit 08ffede)
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Jul 2, 2021
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The default message limit for the gRPC stream is 4MB, which may not be enough for KDS. All resources of a given type are sent in one message (wildcard xDS subscription).
I changed the limit to 10MB and added a parameter to change it.
Without the change, I managed to hit a limit by putting gigantic TrafficPermissions (1000 lines for 1 resource) into global CP. After 350 resources the limit was hit. After the change, I hit the limit after 800 resources.
In practice, we can hit this limit with DataplaneInsights which are pretty big. In the next PR, I'll change the subscription limit for dataplane insights which will be a second thing to help with this problem.
Documentation
Testing