feat(mads) allow specifying fetch-timeout via query param #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `fetch-timeout` query parameter and parses it according to the `time.Duration` spec. Signed-off-by: austin ce <[email protected]>
Signed-off-by: austin ce <[email protected]>
Currently, when the HTTP service writes error responses, the method does not return and continues processing the erroneous request. This commit fixes that. Signed-off-by: austin ce <[email protected]>
Signed-off-by: austin ce <[email protected]>
tharun208
reviewed
Jun 10, 2021
nickolaev
approved these changes
Jun 10, 2021
Signed-off-by: austin ce <[email protected]>
Signed-off-by: austin ce <[email protected]>
This reverts commit 957f712. Signed-off-by: austin ce <[email protected]>
Signed-off-by: austin ce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #2121, adds a query parameter (
fetch-timeout) to allow clients to specify how long a single HTTP long polling request should wait.Originally was thinking a GRPC TimeoutValue and TimeoutUnit made sense as the format, but we use golang's
time.Durationformat elsewhere in the config, and a parser already exists for it, so went with that instead.If the timeout value is less than or equal to 0, the request does a sync fetch instead.
Full changelog
fetch-timeoutquery parameter to the MADS V1 HTTP endpointDocumentation
Testing